Question Set: German translation for "Embed" should be corrected
Submitted by hakangur on Sun, 03/19/2017 - 23:01
I have not tested this with other types of libraries, but there is a major problem with the German translation for the string "Embed" in Question Set. Apparently, a part of the code wass deleted during the translation process. See the attached screenshot.
German translation for "Embed" in Question Set breaks the code.
Mon, 03/20/2017 - 09:18
Hi hakangur, thanks for
Hi hakangur, thanks for reporting this. Could you attach the screenshot again?
Mon, 03/20/2017 - 17:16
I have finished lengthy
I have finished a lengthy online training and now have time again to work on H5P. I'll have a look.
Mon, 03/20/2017 - 19:15
Hmm, I have not been able to
Hmm, I have not been able to observe anything strange (except that some strings still seem to need translation at all on Drupal). Please have a look at the screenshots to confirm that I was looking in the right place.
I checked on Drupal and tried the previous drupal plugin with the previous H5P library versions and also the latest versions of both (1.27 and libraries of March 13). I also checked on Wordpress using the latest plugin and libraries.
Mon, 03/20/2017 - 19:41
Neither have I!
I should have added more detail.
The H5P file was created on a Wordpress website. There, boxes for "Copyright", "Embed" and "Download" were ticked. Then, we downloaded this file and uploaded it on to a Moodle website (as a part of our platform testing process). The initial result was the error I noted above (perhaps because the "embed" feature does not exist in Moodle?). Yet, when I repeated the process today, I did not see a problem. Everything seems fine. I have no idea whatever may have happened but hopefully this was a false alarm.
Tue, 03/21/2017 - 08:12
Alright :) Just write in if
Alright :) Just write in if you see anything else!
Tue, 03/21/2017 - 11:54
I came across the problem on
I came across the problem on a moodle system myself just a few minutes ago. Please check the screenshot that I attached to the file.
It's most certainly a problem of escaping some quotation mark, but I'm rather confused where it might come from. Usind the console, you can verify that the variable H5PIntegration contains an l10n-element called h5pDescription that contains the string including an anchor tag which seems to cause the issue. It seems to be defined within the moodle plugin (locallib.php):
h5ptitle is defined inside the language description of the moodle plugin, but it doesn't contain the formal-German "Sie" phrasing and it never did as far as I could find out. Can't be a problem with an old plugin version then. So, the owner of the moodle site might have changed the string, right? But why would you two face the same issue? Is there an inofficial language file going round or something? I have not checked further, but https://moodle.org/plugins/mod_hvp contains a link saying "Contribute translations for Deutsch (de)" ... Or am I just missing a clue?
Wed, 03/22/2017 - 10:49
Hi, it seems like the
Hi, it seems like the translation is coming from https://lang.moodle.org/, and that it fails because there is an anchor tag in the "title" of an html element, like you indicated. Tbh I don't know exactly how the translations contributions work in Moodle and if anyone can change the translations there or if they have to be approved, but I suspect Moodle has some system in order for this to work well, I guess we just have to set aside some time to get to know it so breaking translations don't happen again.
I have created an issue for looking closer at this problem and figuring out how to tackle it best: https://h5ptechnology.atlassian.net/browse/HFP-853. Thank you for highlighting this issue.
Wed, 03/22/2017 - 12:12
On the Moodle translation website, all translations are checked and approved by a chief editor and sometimes they may fail to notice some problems in translation. Translators themselves cannot change or edit the source text.
Thu, 03/23/2017 - 10:00
Thanks, what is the best way
Thanks, what is the best way to address faulty translations ? Is there a separate chief editor per language, or is there an editor of all languages spanning a plugin ? Is it possible to become a member of the approval team so we can make sure that faulty translations are not automatically pushed to production sites, or do we have to contact the chief translator when this happens ? Thanks for the insight :)
Thu, 03/23/2017 - 12:18
Each language file has an editor ("maintainer") - or sometimes several editors. When you submit a string of translation as an ordinary user, the maintainer receives a message, checks the translation, and approves or disapproves it. Sometimes this process takes a long time because, naturally, maintainers have other things to do as well.
First, join the Moodle website as a member. Then, you can use the link "Translation" on the top menu to get to AMOS - Moodle's translation portal. After that, go to Credits (https://lang.moodle.org/local/amos/credits.php). Here, you can find the list of maintainers for each language. If you intend to contact the maintainers for the English language file itself, for example, choose "English - United States" and send a message to Helen Foster or Mark McCall. Helen Foster is one of the main contributers for Moodle. I believe you can ask her to add you to the list of maintainers for the Norwegian language - if you feel this is necessary.
Thu, 03/23/2017 - 22:18
Thank you for your detailed
Thank you for your detailed explanation :)