Unlock 'activity completion' doesn't work when using H5P in Moodle

Hi, 

Using last version of mod_hvp (1.17.2 (2019031301) in Moodle (version  3.2.9) there is a problem when 'Activity completion' is set.

 

Steps to reproduce...

1. Go to the main page for a course in Moodle

2.  Add a new H5P activity and select any of the activity types available but make sure you set a criteria under 'Activity completion' (E.g: 'Learner must view this activity to complete it')

3. Login as student user in Moodle and go to the course where the above activity was added

4. Enter the H5P activity an complete it

5. Log out as the learner and login as an admin in Moodle

6. Edit the settings for the H5P activity and go under the 'Activity completion' settings 

7. Click any of the buttons 'Unlock completion and delete completion data' or 'Unlock completion and keep completion data' (see screengrab). 

Please notice that clicking the mentioned buttons do not work and completion is not unlocked. Also after clicking any of the buttons you are brought to the course main page instead of staying in the same page what would be the normal behaviour.

 

Browsers: reproduced the above in Firefox 64.0.2 and Chrome 73.0.3683.86

When following the above steps in older versions of H5P everything works as expected

 

Thanks in advance for any help

Summary: 
Buttons not working
Content types: 
BV52's picture

Hi enov-7,

Thank you for reporting this. I created a bug report and you can follow the progress here.

-BV52

Hi, 

Is there any update in the 'activity completion' problem here? 

I see that the ticket that was raised almost 2 month ago is still unassigned: https://h5ptechnology.atlassian.net/browse/HFP-2702

Will be really apreciated if anyone could look at this issue.

Best regards,

BV52's picture

Hi enov-7,

I apologize for the delay the core team still has several projects scheduled. The good thing about H5P is that it is open source and sometimes members of the community creates features and fixes for bugs.

-BV52

Is there a way to speed things along on this bug? It still remains unassigned: https://h5ptechnology.atlassian.net/browse/HFP-2702

I have run into the same problem, as well as a colleague. Not being able to unlock and modify completion criteria was an unpleasant surprise. I would think there are so many Moodle + H5P users globally that this would be important to fix. :(

Best regards,
Marjaana

This is a pretty major bug that has now languished for quite a long time!

This means the *only* way to change completion rules is to *delete* the whole activity and recreate it with (hopefully) the correct rules.

otacke's picture

Hi mhughes2k!

The H5P core team has lots of things to do - some people assume the teams consists of dozens of people, but it doesn't. Luckily, H5P is open source software and is fairly well documented. It shouldn't be a problem to find someone who can fix the issue for you (and others) right now if it's that urgent.

Best,
Oliver